0001-lib-eventlog-Makefile.in-fix-static-build-without-cl.patch 3.2 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455
  1. From 80f86618db50fa5b55c7fdcdc83461a7d6d5f4ea Mon Sep 17 00:00:00 2001
  2. From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
  3. Date: Fri, 22 Jan 2021 07:33:47 +0100
  4. Subject: [PATCH] lib/eventlog/Makefile.in: fix static build without closefrom
  5. Since version 1.9.4 and
  6. https://github.com/sudo-project/sudo/commit/bd1ca79cca827a92e904f022e49df121931d4ff5,
  7. when closefrom is not available, libsudo_eventlog.a depends on
  8. libsudo_util.a. So reflect this dependency in the libtool file to avoid
  9. the following static build failure of logsrvd:
  10. /bin/bash ../libtool --tag=disable-static --mode=link /home/buildroot/autobuild/instance-1/output-1/host/bin/powerpc-linux-gcc -o sudo_logsrvd logsrv_util.o iolog_writer.o logsrvd.o logsrvd_conf.o -static -Wl,--enable-new-dtags -Wl,-z,relro ../lib/iolog/libsudo_iolog.la ../lib/eventlog/libsudo_eventlog.la ../lib/logsrv/liblogsrv.la
  11. /bin/bash ../libtool --tag=disable-static --mode=link /home/buildroot/autobuild/instance-1/output-1/host/bin/powerpc-linux-gcc -o sudo_sendlog logsrv_util.o sendlog.o -static -Wl,--enable-new-dtags -Wl,-z,relro ../lib/iolog/libsudo_iolog.la ../lib/eventlog/libsudo_eventlog.la ../lib/logsrv/liblogsrv.la
  12. libtool: link: /home/buildroot/autobuild/instance-1/output-1/host/bin/powerpc-linux-gcc -o sudo_logsrvd logsrv_util.o iolog_writer.o logsrvd.o logsrvd_conf.o -static -Wl,--enable-new-dtags -Wl,-z -Wl,relro ../lib/iolog/.libs/libsudo_iolog.a /home/buildroot/autobuild/instance-1/output-1/build/sudo-1.9.5p1/lib/util/.libs/libsudo_util.a -lpthread -lz ../lib/eventlog/.libs/libsudo_eventlog.a ../lib/logsrv/.libs/liblogsrv.a
  13. /home/buildroot/autobuild/instance-1/output-1/host/opt/ext-toolchain/bin/../lib/gcc/powerpc-buildroot-linux-uclibc/8.3.0/../../../../powerpc-buildroot-linux-uclibc/bin/ld: ../lib/eventlog/.libs/libsudo_eventlog.a(eventlog.o): in function `send_mail.constprop.1':
  14. eventlog.c:(.text+0x149c): undefined reference to `sudo_closefrom'
  15. collect2: error: ld returned 1 exit status
  16. Fixes:
  17. - http://autobuild.buildroot.org/results/515b45f876fa9de03c9235f86017f4dc10eb3b54
  18. Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
  19. [Upstream status: https://github.com/sudo-project/sudo/commit/c05fe93669e60dba1e290d448254503bd84c8ca3]
  20. ---
  21. lib/eventlog/Makefile.in | 7 ++++---
  22. 1 file changed, 4 insertions(+), 3 deletions(-)
  23. diff --git a/lib/eventlog/Makefile.in b/lib/eventlog/Makefile.in
  24. index a9a279378..134a5d222 100644
  25. --- a/lib/eventlog/Makefile.in
  26. +++ b/lib/eventlog/Makefile.in
  27. @@ -46,8 +46,9 @@ LDFLAGS = @LDFLAGS@
  28. # Flags to pass to libtool
  29. LTFLAGS = @LT_STATIC@
  30. -# Libraries for test programs
  31. -LIBS = $(top_builddir)/lib/util/libsudo_util.la
  32. +# Libraries
  33. +LT_LIBS = $(top_builddir)/lib/util/libsudo_util.la
  34. +LIBS = $(LT_LIBS)
  35. # Address sanitizer flags
  36. ASAN_CFLAGS = @ASAN_CFLAGS@
  37. @@ -132,7 +133,7 @@ $(devdir)/log_server.pb-c.c: $(srcdir)/log_server.proto
  38. fi
  39. libsudo_eventlog.la: $(LIBEVENTLOG_OBJS)
  40. - $(LIBTOOL) $(LTFLAGS) --mode=link $(CC) -o $@ $(LIBEVENTLOG_OBJS)
  41. + $(LIBTOOL) $(LTFLAGS) --mode=link $(CC) -o $@ $(LIBEVENTLOG_OBJS) $(LT_LIBS)
  42. check_wrap: $(CHECK_WRAP_OBJS) $(LIBUTIL)
  43. $(LIBTOOL) $(LTFLAGS) --mode=link $(CC) -o $@ $(CHECK_WRAP_OBJS) $(LDFLAGS) $(ASAN_LDFLAGS) $(PIE_LDFLAGS) $(SSP_LDFLAGS) $(LIBS)
  44. --
  45. 2.29.2