0004-tools-Module.mk-Add-missing-dependencies.patch 2.4 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667
  1. From 08b0d67ba7eceb862cb17f52eb1911e9579726ea Mon Sep 17 00:00:00 2001
  2. From: Jean Delvare <jdelvare@suse.de>
  3. Date: Thu, 14 Dec 2017 08:52:26 +0100
  4. Subject: [PATCH] tools/Module.mk: Add missing dependencies
  5. Better build the library before building the tools which link against
  6. it, otherwise parallel builds could run into a race and break.
  7. Signed-off-by: Jean Delvare <jdelvare@suse.de>
  8. Tested-by: Angelo Compagnucci <angelo@amarulasolutions.com>
  9. Acked-by: Angelo Compagnucci <angelo@amarulasolutions.com>
  10. Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
  11. ---
  12. lib/Module.mk | 7 +++++++
  13. tools/Module.mk | 10 +++++-----
  14. 2 files changed, 12 insertions(+), 5 deletions(-)
  15. diff --git a/lib/Module.mk b/lib/Module.mk
  16. index 8a58f5b..67afe91 100644
  17. --- a/lib/Module.mk
  18. +++ b/lib/Module.mk
  19. @@ -37,6 +37,13 @@ ifeq ($(BUILD_STATIC_LIB),1)
  20. LIB_TARGETS += $(LIB_STLIBNAME)
  21. endif
  22. +# Library file to link against (static or dynamic)
  23. +ifeq ($(USE_STATIC_LIB),1)
  24. +LIB_DEPS := $(LIB_DIR)/$(LIB_STLIBNAME)
  25. +else
  26. +LIB_DEPS := $(LIB_DIR)/$(LIB_SHBASENAME)
  27. +endif
  28. +
  29. #
  30. # Libraries
  31. #
  32. diff --git a/tools/Module.mk b/tools/Module.mk
  33. index 6421a23..609de7a 100644
  34. --- a/tools/Module.mk
  35. +++ b/tools/Module.mk
  36. @@ -24,19 +24,19 @@ TOOLS_TARGETS := i2cdetect i2cdump i2cset i2cget i2ctransfer
  37. # Programs
  38. #
  39. -$(TOOLS_DIR)/i2cdetect: $(TOOLS_DIR)/i2cdetect.o $(TOOLS_DIR)/i2cbusses.o
  40. +$(TOOLS_DIR)/i2cdetect: $(TOOLS_DIR)/i2cdetect.o $(TOOLS_DIR)/i2cbusses.o $(LIB_DEPS)
  41. $(CC) $(LDFLAGS) -o $@ $^ $(TOOLS_LDFLAGS)
  42. -$(TOOLS_DIR)/i2cdump: $(TOOLS_DIR)/i2cdump.o $(TOOLS_DIR)/i2cbusses.o $(TOOLS_DIR)/util.o
  43. +$(TOOLS_DIR)/i2cdump: $(TOOLS_DIR)/i2cdump.o $(TOOLS_DIR)/i2cbusses.o $(TOOLS_DIR)/util.o $(LIB_DEPS)
  44. $(CC) $(LDFLAGS) -o $@ $^ $(TOOLS_LDFLAGS)
  45. -$(TOOLS_DIR)/i2cset: $(TOOLS_DIR)/i2cset.o $(TOOLS_DIR)/i2cbusses.o $(TOOLS_DIR)/util.o
  46. +$(TOOLS_DIR)/i2cset: $(TOOLS_DIR)/i2cset.o $(TOOLS_DIR)/i2cbusses.o $(TOOLS_DIR)/util.o $(LIB_DEPS)
  47. $(CC) $(LDFLAGS) -o $@ $^ $(TOOLS_LDFLAGS)
  48. -$(TOOLS_DIR)/i2cget: $(TOOLS_DIR)/i2cget.o $(TOOLS_DIR)/i2cbusses.o $(TOOLS_DIR)/util.o
  49. +$(TOOLS_DIR)/i2cget: $(TOOLS_DIR)/i2cget.o $(TOOLS_DIR)/i2cbusses.o $(TOOLS_DIR)/util.o $(LIB_DEPS)
  50. $(CC) $(LDFLAGS) -o $@ $^ $(TOOLS_LDFLAGS)
  51. -$(TOOLS_DIR)/i2ctransfer: $(TOOLS_DIR)/i2ctransfer.o $(TOOLS_DIR)/i2cbusses.o $(TOOLS_DIR)/util.o
  52. +$(TOOLS_DIR)/i2ctransfer: $(TOOLS_DIR)/i2ctransfer.o $(TOOLS_DIR)/i2cbusses.o $(TOOLS_DIR)/util.o $(LIB_DEPS)
  53. $(CC) $(LDFLAGS) -o $@ $^ $(TOOLS_LDFLAGS)
  54. #
  55. --
  56. 2.7.4