0001-Fix-the-integer-conversion-error-and-enum-compare-wa.patch 3.7 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879
  1. From 3a1962a70cec74b3dac979e52a2cbcaa8897b9c8 Mon Sep 17 00:00:00 2001
  2. From: Akhilesh Nema <nemaakhilesh@gmail.com>
  3. Date: Fri, 10 Jan 2025 20:20:50 -0800
  4. Subject: [PATCH] Fix the integer conversion error and enum compare
  5. warnings on build under gcc-14
  6. MIME-Version: 1.0
  7. Content-Type: text/plain; charset=UTF-8
  8. Content-Transfer-Encoding: 8bit
  9. Error:
  10. src/fm_lib.c: In function ‘GetDeviceId’:
  11. src/fm_lib.c:139:21: error: returning ‘uintptr_t’ {aka ‘long unsigned int’} from a function with return type ‘t_Handle’ {aka ‘void *’} makes pointer from integer without a cast [-Wint-conversion]
  12. 139 | return p_Dev->id;
  13. | ~~~~~^~~~
  14. Warnings:
  15. src/fm_lib.c: In function ‘FM_PCD_CcRootModifyNextEngine’:
  16. src/fm_lib.c:997:51: warning: comparison between ‘e_FmPcdEngine’ and ‘enum ioc_fm_pcd_engine’ [-Wenum-compare]
  17. 997 | if (p_FmPcdCcNextEngineParams->nextEngine == e_IOC_FM_PCD_FR) {
  18. | ^~
  19. src/fm_lib.c: In function ‘FM_PCD_MatchTableAddKey’:
  20. src/fm_lib.c:1103:57: warning: comparison between ‘e_FmPcdEngine’ and ‘enum ioc_fm_pcd_engine’ [-Wenum-compare]
  21. 1103 | else if (p_KeyParams->ccNextEngineParams.nextEngine == e_IOC_FM_PCD_FR) {
  22. | ^~
  23. src/fm_lib.c: In function ‘FM_PCD_MatchTableModifyKeyAndNextEngine’:
  24. src/fm_lib.c:1174:57: warning: comparison between ‘e_FmPcdEngine’ and ‘enum ioc_fm_pcd_engine’ [-Wenum-compare]
  25. 1174 | else if (p_KeyParams->ccNextEngineParams.nextEngine == e_IOC_FM_PCD_FR) {
  26. Upstream: https://github.com/nxp-qoriq/fmlib/pull/1
  27. Signed-off-by: Akhilesh Nema <nemaakhilesh@gmail.com>
  28. ---
  29. src/fm_lib.c | 8 ++++----
  30. 1 file changed, 4 insertions(+), 4 deletions(-)
  31. diff --git a/src/fm_lib.c b/src/fm_lib.c
  32. index 4ea40ff..85b4a66 100644
  33. --- a/src/fm_lib.c
  34. +++ b/src/fm_lib.c
  35. @@ -136,7 +136,7 @@ t_Handle GetDeviceId(t_Handle h_Dev)
  36. {
  37. t_Device *p_Dev = (t_Device*)h_Dev;
  38. - return p_Dev->id;
  39. + return (t_Handle) p_Dev->id;
  40. }
  41. @@ -994,7 +994,7 @@ t_Error FM_PCD_CcRootModifyNextEngine(t_Handle h_CcTree,
  42. }
  43. #if (DPAA_VERSION >= 11)
  44. - if (p_FmPcdCcNextEngineParams->nextEngine == e_IOC_FM_PCD_FR) {
  45. + if (p_FmPcdCcNextEngineParams->nextEngine == e_FM_PCD_FR) {
  46. t_Device *p_NextDev = (t_Device*) p_FmPcdCcNextEngineParams->params.frParams.h_FrmReplic;
  47. params.cc_next_engine_params.params.fr_params.frm_replic_id = UINT_TO_PTR(p_NextDev->id);
  48. }
  49. @@ -1100,7 +1100,7 @@ t_Error FM_PCD_MatchTableAddKey(t_Handle h_CcNode,
  50. params.key_params.cc_next_engine_params.params.kg_params.p_direct_scheme = UINT_TO_PTR(p_NextDev->id);
  51. }
  52. #if (DPAA_VERSION >= 11)
  53. - else if (p_KeyParams->ccNextEngineParams.nextEngine == e_IOC_FM_PCD_FR) {
  54. + else if (p_KeyParams->ccNextEngineParams.nextEngine == e_FM_PCD_FR) {
  55. t_Device *p_NextDev = (t_Device*) p_KeyParams->ccNextEngineParams.params.frParams.h_FrmReplic;
  56. params.key_params.cc_next_engine_params.params.fr_params.frm_replic_id = UINT_TO_PTR(p_NextDev->id);
  57. }
  58. @@ -1171,7 +1171,7 @@ t_Error FM_PCD_MatchTableModifyKeyAndNextEngine(t_Handle h_CcNode,
  59. params.key_params.cc_next_engine_params.params.kg_params.p_direct_scheme = UINT_TO_PTR(p_NextDev->id);
  60. }
  61. #if (DPAA_VERSION >= 11)
  62. - else if (p_KeyParams->ccNextEngineParams.nextEngine == e_IOC_FM_PCD_FR) {
  63. + else if (p_KeyParams->ccNextEngineParams.nextEngine == e_FM_PCD_FR) {
  64. t_Device *p_NextDev = (t_Device*) p_KeyParams->ccNextEngineParams.params.frParams.h_FrmReplic;
  65. params.key_params.cc_next_engine_params.params.fr_params.frm_replic_id = UINT_TO_PTR(p_NextDev->id);
  66. }
  67. --
  68. 2.25.1