0005-reds-Avoid-integer-overflows-handling-monitor-config.patch 1.0 KB

12345678910111213141516171819202122232425262728293031
  1. From ec6229c79abe05d731953df5f7e9a05ec9f6df79 Mon Sep 17 00:00:00 2001
  2. From: Frediano Ziglio <fziglio@redhat.com>
  3. Date: Mon, 15 May 2017 15:57:28 +0100
  4. Subject: [PATCH] reds: Avoid integer overflows handling monitor
  5. configuration
  6. Avoid VDAgentMessage::size integer overflows.
  7. Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
  8. Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
  9. ---
  10. server/reds.c | 3 +++
  11. 1 file changed, 3 insertions(+)
  12. diff --git a/server/reds.c b/server/reds.c
  13. index 7be85fdf..e1c8c108 100644
  14. --- a/server/reds.c
  15. +++ b/server/reds.c
  16. @@ -1024,6 +1024,9 @@ static void reds_on_main_agent_monitors_config(
  17. spice_debug("not enough data yet. %d", cmc->buffer_size);
  18. return;
  19. }
  20. + if (msg_header->size < sizeof(VDAgentMonitorsConfig)) {
  21. + goto overflow;
  22. + }
  23. monitors_config = (VDAgentMonitorsConfig *)(cmc->buffer + sizeof(*msg_header));
  24. spice_debug("%s: %d", __func__, monitors_config->num_of_monitors);
  25. red_dispatcher_client_monitors_config(monitors_config);
  26. --
  27. 2.11.0