0004-pkcs15init-correct-left-length-calculation-to-fix-buffer-overrun-bug.patch 2.0 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051
  1. From 81944d1529202bd28359bede57c0a15deb65ba8a Mon Sep 17 00:00:00 2001
  2. From: fullwaywang <fullwaywang@tencent.com>
  3. Date: Mon, 29 May 2023 10:38:48 +0800
  4. Subject: [PATCH] pkcs15init: correct left length calculation to fix buffer
  5. overrun bug. Fixes #2785
  6. Upstream: https://github.com/OpenSC/OpenSC/commit/81944d1529202bd28359bede57c0a15deb65ba8a
  7. Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
  8. ---
  9. src/pkcs15init/pkcs15-cardos.c | 10 +++++-----
  10. 1 file changed, 5 insertions(+), 5 deletions(-)
  11. diff --git a/src/pkcs15init/pkcs15-cardos.c b/src/pkcs15init/pkcs15-cardos.c
  12. index 9715cf390f..f41f73c349 100644
  13. --- a/src/pkcs15init/pkcs15-cardos.c
  14. +++ b/src/pkcs15init/pkcs15-cardos.c
  15. @@ -872,7 +872,7 @@ static int cardos_have_verifyrc_package(sc_card_t *card)
  16. sc_apdu_t apdu;
  17. u8 rbuf[SC_MAX_APDU_BUFFER_SIZE];
  18. int r;
  19. - const u8 *p = rbuf, *q;
  20. + const u8 *p = rbuf, *q, *pp;
  21. size_t len, tlen = 0, ilen = 0;
  22. sc_format_apdu(card, &apdu, SC_APDU_CASE_2_SHORT, 0xca, 0x01, 0x88);
  23. @@ -888,13 +888,13 @@ static int cardos_have_verifyrc_package(sc_card_t *card)
  24. return 0;
  25. while (len != 0) {
  26. - p = sc_asn1_find_tag(card->ctx, p, len, 0xe1, &tlen);
  27. - if (p == NULL)
  28. + pp = sc_asn1_find_tag(card->ctx, p, len, 0xe1, &tlen);
  29. + if (pp == NULL)
  30. return 0;
  31. if (card->type == SC_CARD_TYPE_CARDOS_M4_3) {
  32. /* the verifyRC package on CardOS 4.3B use Manufacturer ID 0x01 */
  33. /* and Package Number 0x07 */
  34. - q = sc_asn1_find_tag(card->ctx, p, tlen, 0x01, &ilen);
  35. + q = sc_asn1_find_tag(card->ctx, pp, tlen, 0x01, &ilen);
  36. if (q == NULL || ilen != 4)
  37. return 0;
  38. if (q[0] == 0x07)
  39. @@ -902,7 +902,7 @@ static int cardos_have_verifyrc_package(sc_card_t *card)
  40. } else if (card->type == SC_CARD_TYPE_CARDOS_M4_4) {
  41. /* the verifyRC package on CardOS 4.4 use Manufacturer ID 0x03 */
  42. /* and Package Number 0x02 */
  43. - q = sc_asn1_find_tag(card->ctx, p, tlen, 0x03, &ilen);
  44. + q = sc_asn1_find_tag(card->ctx, pp, tlen, 0x03, &ilen);
  45. if (q == NULL || ilen != 4)
  46. return 0;
  47. if (q[0] == 0x02)