Home Explore Help
Sign In
PUBLIC_REPOS
/
buildroot
mirror of git://git.buildroot.net/buildroot
2
1
Fork 0
Files
Browse Source

package/re2: needs threads

re2 unconditionally uses -pthread and add it to re2.pc

Moreover, it fails to buid without threads on:

In file included from /home/peko/autobuild/instance-0/output-1/per-package/re2/host/opt/ext-toolchain/arm-buildroot-linux-uclibcgnueabihf/include/c++/8.3.0/arm-buildroot-linux-uclibcgnueabihf/bits/os_defines.h:39,
                 from /home/peko/autobuild/instance-0/output-1/per-package/re2/host/opt/ext-toolchain/arm-buildroot-linux-uclibcgnueabihf/include/c++/8.3.0/arm-buildroot-linux-uclibcgnueabihf/bits/c++config.h:508,
                 from /home/peko/autobuild/instance-0/output-1/per-package/re2/host/opt/ext-toolchain/arm-buildroot-linux-uclibcgnueabihf/include/c++/8.3.0/bits/stl_algobase.h:59,
                 from /home/peko/autobuild/instance-0/output-1/per-package/re2/host/opt/ext-toolchain/arm-buildroot-linux-uclibcgnueabihf/include/c++/8.3.0/memory:62,
                 from /home/peko/autobuild/instance-0/output-1/build/re2-2020-08-01/re2/filtered_re2.h:24,
                 from /home/peko/autobuild/instance-0/output-1/build/re2-2020-08-01/re2/filtered_re2.cc:5:
/home/peko/autobuild/instance-0/output-1/per-package/re2/host/arm-buildroot-linux-uclibcgnueabihf/sysroot/usr/include/features.h:218:5: warning: #warning requested reentrant code, but thread support was disabled [-Wcpp]
 #   warning requested reentrant code, but thread support was disabled
     ^~~~~~~
In file included from /home/peko/autobuild/instance-0/output-1/build/re2-2020-08-01/re2/prog.h:22,
                 from /home/peko/autobuild/instance-0/output-1/build/re2-2020-08-01/re2/bitstate.cc:28:
/home/peko/autobuild/instance-0/output-1/build/re2-2020-08-01/re2/re2.h:768:16: error: 'once_flag' in namespace 'std' does not name a type
   mutable std::once_flag rprog_once_;
                ^~~~~~~~~
/home/peko/autobuild/instance-0/output-1/build/re2-2020-08-01/re2/re2.h:768:11: note: 'std::once_flag' is defined in header '<mutex>'; did you forget to '#include <mutex>'?
/home/peko/autobuild/instance-0/output-1/build/re2-2020-08-01/re2/re2.h:218:1:
+#include <mutex>

Fixes:
 - http://autobuild.buildroot.org/results/7d7c6dcac3cb8ea6deb753178e85eb1c5c74c8e3

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Reviewed-by: Michael Nosthoff <buildroot@heine.tech>
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Fabrice Fontaine 4 years ago
parent
a68350f039
commit
f9a2d65cae
2 changed files with 6 additions and 3 deletions
Split View Show Diff Stats
  1. 1 1
      package/grpc/Config.in
  2. 5 2
      package/re2/Config.in

+ 1 - 1
package/grpc/Config.in
View File 

@@ -1,7 +1,7 @@
 
 config BR2_PACKAGE_GRPC
 
 	bool "grpc"
 
 	depends on BR2_INSTALL_LIBSTDCPP
 
-	depends on BR2_TOOLCHAIN_HAS_THREADS # protobuf
 
+	depends on BR2_TOOLCHAIN_HAS_THREADS # protobuf, re2
 
 	depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # protobuf
 
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # protobuf, re2
 
 	depends on !BR2_STATIC_LIBS # protobuf, libabseil-cpp

+ 5 - 2
package/re2/Config.in
View File 

@@ -2,6 +2,7 @@ config BR2_PACKAGE_RE2
 
 	bool "re2"
 
 	depends on BR2_INSTALL_LIBSTDCPP
 
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # needs C++11
 
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 
 	help
 
 	  RE2 is a fast, safe, thread-friendly alternative
 
 	  to backtracking regular expression engines like
 
@@ -10,5 +11,7 @@ config BR2_PACKAGE_RE2
 
 
 	  https://github.com/google/re2
 
 
-comment "re2 needs a toolchain w/ C++, gcc >= 4.8"
 
-	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
 
+comment "re2 needs a toolchain w/ C++, threads, gcc >= 4.8"
 
+	depends on !BR2_INSTALL_LIBSTDCPP || \
 
+		!BR2_TOOLCHAIN_HAS_THREADS || \
 
+		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8