소스 검색

package/icu: don't disable renaming for host build

Using a different renaming option for the icu host build can cause
issues for packages such as qt5webengine which expect target and
host packages to be built with the same options.

A package that needs both host and target to have the same options is most
probably doing somethig wrong, like linking a host program and taking the
result as valid for the target.

However, our adding the --disable-renaming in the first place in 3911e67151b
(icu: security bump to version 51.2) did not provide any explanations why it
was needed to begin with, so drop it.

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Reviewed-by: Yann E. MORIN <yann.morin.1998@free.fr>
[Peter: extend commit message as suggested by Yann]
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
James Hilliard 3 년 전
부모
커밋
f93039e3a6
2개의 변경된 파일2개의 추가작업 그리고 3개의 파일을 삭제
  1. 1 2
      package/icu/icu.mk
  2. 1 1
      package/nodejs/nodejs.mk

+ 1 - 2
package/icu/icu.mk

@@ -45,8 +45,7 @@ HOST_ICU_CONF_OPTS = \
 	--disable-tests \
 	--disable-extras \
 	--disable-icuio \
-	--disable-layout \
-	--disable-renaming
+	--disable-layout
 ICU_SUBDIR = source
 HOST_ICU_SUBDIR = source
 

+ 1 - 1
package/nodejs/nodejs.mk

@@ -94,7 +94,7 @@ NODEJS_HOST_TOOLS_V8 = \
 NODEJS_HOST_TOOLS_NODE = mkcodecache
 NODEJS_HOST_TOOLS = $(NODEJS_HOST_TOOLS_V8) $(NODEJS_HOST_TOOLS_NODE)
 
-HOST_NODEJS_CXXFLAGS = $(HOST_CXXFLAGS) -DU_DISABLE_RENAMING=1
+HOST_NODEJS_CXXFLAGS = $(HOST_CXXFLAGS)
 
 define HOST_NODEJS_BUILD_CMDS
 	$(HOST_MAKE_ENV) PYTHON=$(HOST_DIR)/bin/python3 \