Bladeren bron

package/dvb-apps: is not parallel-safe

This is invisible because the timings make it excessively difficult to
hit, but the Makefile is inherently flawed for parallel build, as it
contains:

    $(objects): atsc_psip_section.c atsc_psip_section.h

    atsc_psip_section.c atsc_psip_section.h:
        perl section_generate.pl atsc_psip_section.pl

and the perl script section_generate.pl will create both the .c and .h
files in one go, but given the construct above, there can be two such
script that run in parallel, which can clobber the generated .c and/or
.h files.

So, make dvb-apps a MAKE1 package.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
(cherry picked from commit ba6796c7ccb856fc34a7983c9ac031168f1e0b65)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Yann E. MORIN 7 jaren geleden
bovenliggende
commit
bce795fbdc
1 gewijzigde bestanden met toevoegingen van 1 en 1 verwijderingen
  1. 1 1
      package/dvb-apps/dvb-apps.mk

+ 1 - 1
package/dvb-apps/dvb-apps.mk

@@ -25,7 +25,7 @@ DVB_APPS_INSTALL_STAGING = YES
 
 
 define DVB_APPS_BUILD_CMDS
 define DVB_APPS_BUILD_CMDS
 	$(TARGET_CONFIGURE_OPTS) LDLIBS="$(DVB_APPS_LDLIBS)" \
 	$(TARGET_CONFIGURE_OPTS) LDLIBS="$(DVB_APPS_LDLIBS)" \
-		$(MAKE) -C $(@D) CROSS_ROOT=$(STAGING_DIR) \
+		$(MAKE1) -C $(@D) CROSS_ROOT=$(STAGING_DIR) \
 		$(DVB_APPS_MAKE_OPTS)
 		$(DVB_APPS_MAKE_OPTS)
 endef
 endef