package/bcusdk: fix build with host GCC 14.x

With GCC 14.x as the host compiler, bcusdk fails to build as follows:

configure: error: Specified CC_FOR_BUILD doesn't seem to work

This is due to missing includes in the test programs used in the
configure script to check the host compiler. We fix this with patch
0003.

However, this patch requires to autoreconf the package, and autoreconf
would need the definition of AM_PATH_XML2, which would require libxml2
even though we don't have libxml2 as a dependency of this package (we
don't enable the features that requires libxml2). As it turns out that
the AM_PATH_XML2 macro is in fact deprecated, we replaced it by its
equivalent using PKG_CHECK_MODULES(), which is in fact exactly how
AM_PATH_XML2 is implemented in upstream libxml2.

Fixes:

  http://autobuild.buildroot.net/results/458880bd6c207e5bb7afce1a1186f204c30c0941/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
(cherry picked from commit e4109c1d2d28f737409dce2e346661cbf20084c6)
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

package/bcusdk/0003-m4-ccforbuild.m4-include-stdlib.h-in-test-program.patch

@@ -0,0 +1,50 @@
+From 1c78aa3541f730e9624504168fb0e1f413e5cbb8 Mon Sep 17 00:00:00 2001
+From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
+Date: Fri, 2 Aug 2024 19:28:36 +0200
+Subject: [PATCH] m4/ccforbuild.m4: include <stdlib.h> in test program
+
+The GMP_PROG_CC_FOR_BUILD_WORKS and GMP_PROG_EXEEXT_FOR_BUILD macros
+do various checks to verify if the host compiler works, but their test
+programs lack the inclusion of <stdlib.h>, needed for exit(). This
+causes a build failure with gcc 14.x:
+
+conftest.c: In function 'main':
+conftest.c:4:3: error: implicit declaration of function 'exit' [-Wimplicit-function-declaration]
+    4 |   exit(0);
+
+which then causes the configure script to think that the host compiler
+does not work:
+
+configure: error: Specified CC_FOR_BUILD doesn't seem to work
+
+so let's include <stdlib.h> to fix this issue.
+
+Upstream: https://sourceforge.net/p/bcusdk/patches/4/
+Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
+---
+ m4/ccforbuild.m4 | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/m4/ccforbuild.m4 b/m4/ccforbuild.m4
+index a466cab..389deaa 100644
+--- a/m4/ccforbuild.m4
++++ b/m4/ccforbuild.m4
+@@ -66,6 +66,7 @@ AC_DEFUN([GMP_PROG_CC_FOR_BUILD_WORKS],
+ # remove anything that might look like compiler output to our "||" expression
+ rm -f conftest* a.out b.out a.exe a_out.exe
+ cat >conftest.c <<EOF
++#include <stdlib.h>
+ int
+ main ()
+ {
+@@ -140,6 +141,7 @@ AC_DEFUN([GMP_PROG_EXEEXT_FOR_BUILD],
+ AC_CACHE_CHECK([for build system executable suffix],
+                gmp_cv_prog_exeext_for_build,
+ [cat >conftest.c <<EOF
++#include <stdlib.h>
+ int
+ main ()
+ {
+-- 
+2.45.2
+

package/bcusdk/0004-configure.in-replace-obsolete-AM_PATH_XML2-by-PKG_CH.patch

@@ -0,0 +1,40 @@
+From 8402c1ffccb2eeb47581d2d80b81e94433cdacb7 Mon Sep 17 00:00:00 2001
+From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
+Date: Fri, 2 Aug 2024 19:35:02 +0200
+Subject: [PATCH] configure.in: replace obsolete AM_PATH_XML2 by
+ PKG_CHECK_MODULES
+
+According to the libxml2 code:
+
+  AM_PATH_XML2 is deprecated, use PKG_CHECK_MODULES instead
+
+See:
+
+  https://gitlab.gnome.org/GNOME/libxml2/-/blob/master/libxml.m4
+
+Upstream: https://sourceforge.net/p/bcusdk/patches/5/
+Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
+---
+ configure.in | 6 +++++-
+ 1 file changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/configure.in b/configure.in
+index 7f3a8bd..82176d9 100644
+--- a/configure.in
++++ b/configure.in
+@@ -81,7 +81,11 @@ AM_CONDITIONAL(HAVE_ONLYEIBD, test x$onlyeibd = xtrue)
+ 
+ if test x$onlyeibd = xfalse ; then
+ 
+-AM_PATH_XML2(2.6.16,,[AC_MSG_ERROR([limxml2 not found])])
++PKG_CHECK_MODULES(XML, [libxml-2.0 >= 2.6.16], [], [AC_MSG_ERROR([limxml2 not found])])
++XML_CPPFLAGS=$XML_CFLAGS
++AC_SUBST(XML_CPPFLAGS)
++AC_SUBST(XML_LIBS)
++
+ AC_PATH_PROG(TAS,[m68hc05-as],,[$PATH:$bindir:$prefix/bin])
+ AC_PATH_PROG(TLD,[m68hc05-ld],,[$PATH:$bindir:$prefix/bin])
+ AC_PATH_PROG(TAR,[m68hc05-ar],,[$PATH:$bindir:$prefix/bin])
+-- 
+2.45.2
+

package/bcusdk/bcusdk.mk

@@ -10,6 +10,9 @@ BCUSDK_SITE = http://www.auto.tuwien.ac.at/~mkoegler/eib
 BCUSDK_LICENSE = GPL-2.0+
 BCUSDK_LICENSE_FILES = COPYING
 BCUSDK_INSTALL_STAGING = YES
+# 0003-m4-ccforbuild.m4-include-stdlib.h-in-test-program.patch
+# 0004-configure.in-replace-obsolete-AM_PATH_XML2-by-PKG_CH.patch
+BCUSDK_AUTORECONF = YES
 BCUSDK_CONF_OPTS = \
 	--enable-onlyeibd \
 	--enable-ft12 \
@@ -21,7 +24,8 @@ BCUSDK_CONF_OPTS = \
 	--without-pth-test \
 	--with-pth=$(STAGING_DIR)/usr
 
-BCUSDK_DEPENDENCIES = libpthsem
+# host-pkgconf is only needed because of autoreconf
+BCUSDK_DEPENDENCIES = libpthsem host-pkgconf
 
 ifeq ($(BR2_PACKAGE_ARGP_STANDALONE),y)
 BCUSDK_DEPENDENCIES += argp-standalone $(TARGET_NLS_DEPENDENCIES)