瀏覽代碼

package/kodi/br-kodi: fix shellcheck SC2317 & SC2329

As stated in shellcheck wiki about SC2329 [1]

  "ShellCheck is currently bad at figuring out functions that are invoked via trap.
   In such cases, please ignore the message with a directive."

While adding SC2329 check after shellcheck v0.10.0 release, it also
reduced the amount of false result returned by shellcheck v0.9.0.

So disable SC2317 and SC2329.

[1] https://www.shellcheck.net/wiki/SC2329
[2] https://github.com/koalaman/shellcheck/commit/4f81dbe839091a06a5cfaea695cf1c451ff07565

Signed-off-by: Romain Naour <romain.naour@smile.fr>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Romain Naour 5 月之前
父節點
當前提交
48ccb7d1d7
共有 1 個文件被更改,包括 2 次插入0 次删除
  1. 2 0
      package/kodi/br-kodi

+ 2 - 0
package/kodi/br-kodi

@@ -5,6 +5,8 @@
 KODI="${1}"
 shift
 
+# shellcheck disable=SC2329 # https://www.shellcheck.net/wiki/SC2329
+# shellcheck disable=SC2317 # shellcheck 0.9.0 "spammy"
 # In case someone asked we terminate, just kill
 # the Kodi process
 trap_kill() {