瀏覽代碼

graph-depends: rename the mode constants

This is ugly, since Python does not have enum constructs, so by moving
the 'type' of the constant ('MODE' here) to the beginning, we get an
artificial 'namespace' for the constants.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Cc: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Yann E. MORIN 11 年之前
父節點
當前提交
47aeebd956
共有 1 個文件被更改,包括 8 次插入12 次删除
  1. 8 12
      support/scripts/graph-depends

+ 8 - 12
support/scripts/graph-depends

@@ -25,13 +25,9 @@ import sys
 import subprocess
 import subprocess
 import argparse
 import argparse
 
 
-# In FULL_MODE, we draw the full dependency graph for all selected
-# packages
-FULL_MODE = 1
-
-# In PKG_MODE, we only draw the dependency graph for a given package
-PKG_MODE  = 2
-
+# Modes of operation:
+MODE_FULL = 1   # draw full dependency graph for all selected packages
+MODE_PKG  = 2   # draw dependency graph for a given package
 mode = 0
 mode = 0
 
 
 # Limit drawing the dependency graph to this depth. 0 means 'no limit'.
 # Limit drawing the dependency graph to this depth. 0 means 'no limit'.
@@ -58,9 +54,9 @@ parser.add_argument("--no-transitive", dest="transitive", action='store_false',
 args = parser.parse_args()
 args = parser.parse_args()
 
 
 if args.package is None:
 if args.package is None:
-    mode = FULL_MODE
+    mode = MODE_FULL
 else:
 else:
-    mode = PKG_MODE
+    mode = MODE_PKG
     rootpkg = args.package
     rootpkg = args.package
 
 
 max_depth = args.depth
 max_depth = args.depth
@@ -183,7 +179,7 @@ TARGET_EXCEPTIONS = [
 
 
 # In full mode, start with the result of get_targets() to get the main
 # In full mode, start with the result of get_targets() to get the main
 # targets and then use get_all_depends() for all targets
 # targets and then use get_all_depends() for all targets
-if mode == FULL_MODE:
+if mode == MODE_FULL:
     targets = get_targets()
     targets = get_targets()
     dependencies = []
     dependencies = []
     allpkgs.append('all')
     allpkgs.append('all')
@@ -201,7 +197,7 @@ if mode == FULL_MODE:
 
 
 # In pkg mode, start directly with get_all_depends() on the requested
 # In pkg mode, start directly with get_all_depends() on the requested
 # package
 # package
-elif mode == PKG_MODE:
+elif mode == MODE_PKG:
     dependencies = get_all_depends([rootpkg])
     dependencies = get_all_depends([rootpkg])
 
 
 # Make the dependencies a dictionnary { 'pkg':[dep1, dep2, ...] }
 # Make the dependencies a dictionnary { 'pkg':[dep1, dep2, ...] }
@@ -269,7 +265,7 @@ def print_attrs(pkg):
         label = 'ALL'
         label = 'ALL'
     else:
     else:
         label = pkg
         label = pkg
-    if pkg == 'all' or (mode == PKG_MODE and pkg == rootpkg):
+    if pkg == 'all' or (mode == MODE_PKG and pkg == rootpkg):
         color = root_colour
         color = root_colour
     else:
     else:
         if pkg.startswith('host') \
         if pkg.startswith('host') \